Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] Upgrade typescript to 3.6 #2428

Merged
merged 2 commits into from
Oct 18, 2019

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Oct 18, 2019

typescript 3.6 has better type inference + a lot of useful new features.

Painful issues we met in typescript 3.3:

/area front-end
/assign @rmgogogo


This change is Reviewable

@Bobgy
Copy link
Contributor Author

Bobgy commented Oct 18, 2019

/test kubeflow-pipeline-sample-test

@rmgogogo
Copy link
Contributor

/lgtm

@Bobgy
Copy link
Contributor Author

Bobgy commented Oct 18, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7ce65b0 into kubeflow:master Oct 18, 2019
@Bobgy Bobgy deleted the fe_upgrade_typescript branch October 21, 2019 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants