Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnose me dev env #2425

Merged
merged 5 commits into from
Oct 23, 2019
Merged

Conversation

SinaChavoshi
Copy link
Contributor

@SinaChavoshi SinaChavoshi commented Oct 17, 2019

Adding libraries for diagnose me dev env .


This change is Reviewable

Copy link
Contributor

@hongye-sun hongye-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@SinaChavoshi
Copy link
Contributor Author

/assign @gaoning777

@hongye-sun
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm label Oct 22, 2019
@Ark-kun
Copy link
Contributor

Ark-kun commented Oct 23, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SinaChavoshi SinaChavoshi merged commit 3386a4b into kubeflow:master Oct 23, 2019
@SinaChavoshi SinaChavoshi deleted the diagnose_me_dev_env branch November 4, 2019 19:04
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* adding prom metrics in python sdk custom transformer, tests, and documentation

Signed-off-by: alexagriffith <agriffith50@bloomberg.net>
Signed-off-by: alexagriffith <agriffith96@gmail.com>
Signed-off-by: alexagriffith <agriffith50@bloomberg.net>

* lint
Signed-off-by: alexagriffith <agriffith50@bloomberg.net>

Signed-off-by: alexagriffith <agriffith50@bloomberg.net>

Signed-off-by: alexagriffith <agriffith50@bloomberg.net>
Signed-off-by: alexagriffith <agriffith96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants