[Doc] Update permission requirement in README #2422
Conversation
| @@ -13,6 +13,8 @@ or not. | |||
| ## Requirements | |||
|
|
|||
| Preprocessing uses Google Cloud DataProc. Therefore, you must enable the [DataProc API](https://cloud.google.com/endpoints/docs/openapi/enable-api) for the given GCP project. | |||
| If KFP was deployed through K8S marketplace, please follow instructions in [the guideline](https://github.com/kubeflow/pipelines/blob/master/manifests/gcp_marketplace/guide.md#gcp-service-account-credentials) | |||
| to make sure the service account used has the role `storage.admin` and `dataproc.admin`. | |||
There was a problem hiding this comment.
Probably also add the API enabled requirement, such as "enable the DataProc API for the given GCP project"
There was a problem hiding this comment.
We can have a direct link to enabling that API.
There was a problem hiding this comment.
Add a link to the API page.
@Ark-kun are you saying there is a direct link that can enable the API within one-click? If so that'll be better.
There was a problem hiding this comment.
When you try running a Dataproc or Dataflow component, that link is in the error log.
Here is the Dataflow link: https://console.cloud.google.com/apis/api/dataflow.googleapis.com/overview?project=1234567
…ix-doc # Conflicts: # samples/contrib/parameterized_tfx_oss/README.md
|
/lgtm |
|
/retest |
1 similar comment
|
/retest |
|
Updated my comments. I assume this PR can be submitted on your Monday. (Yang can provide approval, no need to wait for my approval) |
|
/lgtm Please address other's comment. I'm generally OK. As long as the link in pipeline list can well refer to the doc. |
|
/approve |
|
New changes are detected. LGTM label has been removed. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan, numerology The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is specifically needed for MKP deployment. XGBoost sample needs storage and dataproc permission and TFX sample needs storage permission.
This change is