Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Minor doc update #2394

Merged
merged 7 commits into from
Oct 24, 2019
Merged

[Doc] Minor doc update #2394

merged 7 commits into from
Oct 24, 2019

Conversation

numerology
Copy link

@numerology numerology commented Oct 15, 2019

Reminding MacOS users not to include -w 0 option when generating token.

Switch to a simpler way for secret injection.


This change is Reviewable

@numerology
Copy link
Author

/retest

@IronPan
Copy link
Member

IronPan commented Oct 18, 2019

/lgtm
/approve

@IronPan
Copy link
Member

IronPan commented Oct 18, 2019

/hold

@IronPan
Copy link
Member

IronPan commented Oct 23, 2019

/lgtm

@IronPan
Copy link
Member

IronPan commented Oct 23, 2019

@numerology @rmgogogo PTAL

@k8s-ci-robot k8s-ci-robot removed the lgtm label Oct 23, 2019
@numerology
Copy link
Author

@IronPan Merged with head, PTAL thanks!

@IronPan
Copy link
Member

IronPan commented Oct 24, 2019

/lgtm
/approve
/hold cancel

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@numerology
Copy link
Author

/retest

@numerology
Copy link
Author

/hold missing namespace

@k8s-ci-robot k8s-ci-robot removed the lgtm label Oct 24, 2019
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@numerology numerology requested a review from Bobgy October 24, 2019 04:43
@numerology
Copy link
Author

/hold cancel

Copy link
Contributor

@Bobgy Bobgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @numerology! This looks good
/lgtm

@Bobgy Bobgy added the lgtm label Oct 24, 2019
@k8s-ci-robot k8s-ci-robot merged commit 868b135 into kubeflow:master Oct 24, 2019
@numerology numerology deleted the fix-mkp-doc branch October 24, 2019 15:53
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* fix: update readme doc

Signed-off-by: Jagadeesh J <jagadeeshj@ideas2it.com>

* Update torchserve transformer doc

Signed-off-by: Jagadeesh J <jagadeeshj@ideas2it.com>

* fix: website url

Signed-off-by: Jagadeesh J <jagadeeshj@ideas2it.com>

Signed-off-by: Jagadeesh J <jagadeeshj@ideas2it.com>
Co-authored-by: Dan Sun <dsun20@bloomberg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants