Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License crawler for third party golang libraries #2393

Merged
merged 7 commits into from
Oct 25, 2019

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Oct 15, 2019

A set of CLI tools to automatically crawl license info for third party golang libraries.

Please first review CLI README for the overall workflow: https://github.com/kubeflow/pipelines/pull/2393/files#diff-d58ea8967fc24137b9d349dd2391e2b1

Also a trick is to filter out all csv and txt files when reviewing: https://github.com/kubeflow/pipelines/pull/2393/files?file-filters%5B%5D=.md&file-filters%5B%5D=.py&file-filters%5B%5D=dotfile it leaves only important stuff for review

File generation dependency graph is like:

    get-github-repo   get-github-license-info      concatenate-license
dep.txt =========>repo.txt =========> license_info.csv ======> license.txt
          //
with dep-repo-mapping.manual.csv

dep.txt: list of golang dependency names
repo.txt: list of github repos
license_info.csv: list of repo name, license html url, license name, license download url
license.txt: concatenated license file

/assign @Ark-kun
/cc @neuromage
/cc @IronPan


This change is Reviewable

@Ark-kun
Copy link
Contributor

Ark-kun commented Oct 18, 2019

/lgtm
@IronPan Can you please take a look?

@IronPan
Copy link
Member

IronPan commented Oct 25, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@IronPan
Copy link
Member

IronPan commented Oct 25, 2019

Thank you @Bobgy this is awesome.

@k8s-ci-robot k8s-ci-robot merged commit 3bda9e8 into kubeflow:master Oct 25, 2019
@Bobgy Bobgy deleted the 3rd_party_license_crawler branch October 25, 2019 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants