Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move favicon path, root is override by inverse proxy #2382

Merged
merged 2 commits into from
Oct 14, 2019
Merged

move favicon path, root is override by inverse proxy #2382

merged 2 commits into from
Oct 14, 2019

Conversation

rmgogogo
Copy link
Contributor

@rmgogogo rmgogogo commented Oct 14, 2019

root is override by inverse proxy, so in MKP path, the icon got gone


This change is Reviewable

@Bobgy
Copy link
Contributor

Bobgy commented Oct 14, 2019

/lgtm

@rmgogogo
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rmgogogo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants