Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tech writer edits #2373

Merged
merged 2 commits into from
Oct 17, 2019
Merged

tech writer edits #2373

merged 2 commits into from
Oct 17, 2019

Conversation

jay-saldanha
Copy link
Contributor

@jay-saldanha jay-saldanha commented Oct 11, 2019

@hongye-sun please merge the edits


This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @jay-saldanha. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

components/gcp/ml_engine/train/README.md Show resolved Hide resolved
@@ -1,33 +1,51 @@

# Name
Submitting a Cloud Machine Learning Engine training job as a pipeline step
Component: Submitting an AI Platform training job as a pipeline step
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed CLoud ML Engine to AI Platform all over the readme

@numerology
Copy link

/ok-to-test

@hongye-sun
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongye-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3c4702c into kubeflow:master Oct 17, 2019
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Adds S3 configuration options through the following
- `inferenceservice` configmap (global options)
- k8s service account annotations for AWS IRSA
- k8s secret annotations attached to k8s service account for static
  credentials

Signed-off-by: Matthew Rose <matthew.rose@maxkelsen.com>

Signed-off-by: Matthew Rose <matthew.rose@maxkelsen.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants