[Sample] Improve tfx oss sample #2360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
…mprove-tfx-oss-sample
Ark-kun
reviewed
Oct 11, 2019
test/sample-test/run_sample_test.py
Outdated
| self._test_args['pipeline-root'] = os.path.join(self._test_args['output'], 'tfx_taxi_simple') | ||
| self._test_args['pipeline-root'] = os.path.join( | ||
| self._test_args['output'], | ||
| 'tfx_taxi_simple_' + str(int(time.time()))) |
There was a problem hiding this comment.
You might also use the kfp.dsl.RUN_ID_PLACEHOLDER.
There was a problem hiding this comment.
Good idea. I think that's better
|
/lgtm |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
* Pass request headers to predict method (kubeflow#2284) * Pass inference request headers to model's predict method Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Fixed liniting error Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Added changes for passing headers in explainer Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Changes for explainer and changed field name to payload from request Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Fixed import errors and added header in preprocess Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * pass-headers-debug Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Added container logs in status check. Changed function signature hints. Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Reverted import re-ordering Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Updated param order hint Made changes to copy only request id and trace id Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did two things here:
Fixes #2354
This change is