Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch default tag to strongly typed version number #234

Merged
merged 2 commits into from
Nov 17, 2018
Merged

switch default tag to strongly typed version number #234

merged 2 commits into from
Nov 17, 2018

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Nov 13, 2018 •
edited by jlewi
Loading

Having strongly versioned image tag would help identifying issue more efficiently. We should consider avoid latest tag even though it's just default value.

This change is Reviewable

@IronPan
Copy link
Member Author

IronPan commented Nov 13, 2018 •
edited
Loading

/assign @gaoning777 @Ark-kun

@coveralls
Copy link

Pull Request Test Coverage Report for Build 289

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.531%
Totals Coverage Status
Change from base Build 279: 0.0%
Covered Lines: 1542
Relevant Lines: 2193
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 329

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.531%
Totals Coverage Status
Change from base Build 279: 0.0%
Covered Lines: 1542
Relevant Lines: 2193
💛 - Coveralls

@IronPan
Copy link
Member Author

IronPan commented Nov 13, 2018

/assign @Ark-kun @gaoning777

Ark-kun
Ark-kun approved these changes Nov 14, 2018
View reviewed changes
Copy link
Contributor

@Ark-kun Ark-kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like this PR to be merged after #232 which changes some of these files too.

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 14, 2018

@IronPan Can this PR wait for #232 or do you need it to be merged ASAP?

@IronPan
Copy link
Member Author

IronPan commented Nov 14, 2018

No worry. This is not urgent.

@IronPan IronPan added lgtm and removed lgtm labels Nov 17, 2018
@IronPan IronPan changed the base branch from master to IronPan-patch-1 November 17, 2018 02:33
@IronPan IronPan changed the base branch from IronPan-patch-1 to master November 17, 2018 02:33
@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 17, 2018

/lgtm

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 17, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e0e8ca7 into master Nov 17, 2018
@IronPan IronPan deleted the yangpa/version branch December 10, 2018 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ark-kun Ark-kun Ark-kun approved these changes

@qimingj qimingj Awaiting requested review from qimingj

Assignees

@Ark-kun Ark-kun

@gaoning777 gaoning777

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@IronPan @coveralls @Ark-kun @k8s-ci-robot @gaoning777