Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests - When testing SDK install it using pip #2325

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Oct 8, 2019

pip is the preferred way now. It runs faster, better support binary wheels and produces less log noise.

This change is Reviewable

@Ark-kun Ark-kun changed the title Tests - When testing SDK install using pip Tests - When testing SDK install it using pip Oct 8, 2019
@Ark-kun Ark-kun force-pushed the Tests---When-testing-SDK-install-using-pip branch from b2b7afb to e8854f9 Compare October 8, 2019 03:28
Coveralls paths "diverge" again.
@neuromage
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neuromage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b2469d8 into kubeflow:master Oct 10, 2019
@Ark-kun Ark-kun deleted the Tests---When-testing-SDK-install-using-pip branch October 10, 2019 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants