Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for MKP #2288

Merged
merged 2 commits into from
Oct 2, 2019
Merged

fix for MKP #2288

merged 2 commits into from
Oct 2, 2019

Conversation

rmgogogo
Copy link
Contributor

@rmgogogo rmgogogo commented Oct 2, 2019

This change is Reviewable

@neuromage
Copy link
Contributor

/lgtm
/approve
Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neuromage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit bf81e63 into kubeflow:master Oct 2, 2019
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
When an InferenceService predictor is deployed to ModelMesh, the
defaulting webhook is still adding things to the predictor spec.
This changes it so no modifications to the predictor spec are done
so that it will pass through as is for the ModelMesh controller to
process.

Signed-off-by: Paul Van Eck <pvaneck@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants