Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tech writer edits #2285

Merged
merged 2 commits into from
Oct 3, 2019
Merged

tech writer edits #2285

merged 2 commits into from
Oct 3, 2019

Conversation

jay-saldanha
Copy link
Contributor

@jay-saldanha jay-saldanha commented Oct 1, 2019 •
edited by jlewi
Loading

@hongye-sun I have edited these please review. Add facets at line 12.

This change is Reviewable

@jay-saldanha
tech writer edits
1c7dc3e 
@hongye-sun I have edited these please review. Add facets at line 12.
@k8s-ci-robot
Copy link
Contributor

Hi @jay-saldanha. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hongye-sun
Copy link
Contributor

/ok-to-test
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongye-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e56dc20 into kubeflow:master Oct 3, 2019
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@pvaneck
chore: Disable storage spec type validation (kubeflow#2285)
deeda68 
Due to differences in storage provider support between the
KServe storage initializer and ModelMesh puller, this commit
disables the storage spec type validation. With this enabled,
Isvcs on ModelMesh trying to use the new storage spec with azure or gcs
providers will be blocked by KServe's validation webhook. This
check could potentially be re-enabled once gs/azure storage spec
support is provided in the storage initializer.

Signed-off-by: Paul Van Eck <pvaneck@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@animeshsingh animeshsingh Awaiting requested review from animeshsingh

@gaoning777 gaoning777 Awaiting requested review from gaoning777

Assignees

@hongye-sun hongye-sun

Labels
approved lgtm ok-to-test size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jay-saldanha @k8s-ci-robot @hongye-sun