Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components - Added the "AutoML Export data to GCS" component #2278

Merged
merged 1 commit into from
Oct 17, 2019
Merged

Components - Added the "AutoML Export data to GCS" component #2278

merged 1 commit into from
Oct 17, 2019

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Oct 1, 2019 •
edited by jlewi
Loading

This change is Reviewable

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Oct 1, 2019

Pending a possible internal AutoML bug I've encountered
/hold

@Ark-kun Ark-kun removed the request for review from animeshsingh October 1, 2019 04:50
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Oct 1, 2019

/retest

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Oct 5, 2019

/retest

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Oct 5, 2019

The AutoML confirmed that the issue is by design:
Exporting to GCS is only possible if data was imported from GCS.
Exporting to BQ is only possible if data was imported from BQ.

They're going to improve error messages to show proper errors.

/hold cancel

SinaChavoshi
SinaChavoshi approved these changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@SinaChavoshi SinaChavoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

components/gcp/automl/export_data_to_gcs/component.py Show resolved Hide resolved
components/gcp/automl/export_data_to_gcs/component.py
metadata = response.metadata
print('Operation finished:')
print(metadata)
return (gcs_output_uri_prefix, )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: no space after , ..._prefix,)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. Would this 1-tuple still be as readable without that space?

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Oct 17, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6e33c79 into kubeflow:master Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SinaChavoshi SinaChavoshi SinaChavoshi approved these changes

@paveldournov paveldournov Awaiting requested review from paveldournov

@hongye-sun hongye-sun Awaiting requested review from hongye-sun

Assignees

@paveldournov paveldournov

@SinaChavoshi SinaChavoshi

Labels
approved area/components lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ark-kun @k8s-ci-robot @SinaChavoshi @paveldournov