Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Components - Fix - Stop serializing string values #2227

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Sep 25, 2019

This can happen with Lightweight component outputs if they've already been serialized manually.


This change is Reviewable

This can happen with Lightweight component outputs if they've already been serialized manually.
@numerology
Copy link

/lgtm

Just to confirm, this won't actually change the behavior because json.dump a string still returns the same string, right?

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Sep 26, 2019

Just to confirm, this won't actually change the behavior because json.dump a string still returns the same string, right?

It changes/fixes the behavior of the serializer since json.jumps('string') == '"string"' - the quotes are added.

Fortunately, the problem was never triggerable in most code paths, because the serialize_value was checking the object type and never run serializers on strings. The only code path where this became a problem was introduced just 2 days ago in #2198 .

@Ark-kun Ark-kun changed the title SDK - Components - Stop serializing string values SDK - Components - Fix - Stop serializing string values Sep 26, 2019
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Sep 26, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Sep 26, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 7735a14 into kubeflow:master Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants