third_party/metadata_envoy: Modify license file #2224
Conversation
|
/assign @IronPan |
|
/test kubeflow-pipeline-e2e-test |
|
/test kubeflow-pipeline-sample-test |
1 similar comment
|
/test kubeflow-pipeline-sample-test |
| @@ -1,5 +1,4 @@ | |||
| { | |||
| "target_path": "/third_party", | |||
| "libraries": [ | |||
There was a problem hiding this comment.
Hi, I think you should also include license for envoy itself.
There was a problem hiding this comment.
Thanks for the catch. Fixed it.
|
|
||
| RUN pip uninstall --yes wget | ||
| RUN apt-get remove --yes --purge python-setuptools python-pip python | ||
| RUN mkdir -p /third_party |
There was a problem hiding this comment.
nit: My understanding is you don't need this line. COPY already does this.
If <dest> doesn’t exist, it is created along with all missing directories in its path.
reference: https://docs.docker.com/engine/reference/builder/#copy
Change to update the approach to add license files to the third_party/metadata_envoy docker image. This update moves from the model of downloading the license files in each build to downloading it locally to a license.txt file, checking the file in and using it to store in the docker image.
dushyanthsc
force-pushed
the
dushyanthsc/metadata-envoy-license-fix
branch
from
3e4e531
to
9b2705b
Compare
|
/test kubeflow-pipeline-e2e-test |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Change to update the approach to add license files to the third_party/metadata_envoy docker image. This update moves from the model of downloading the license files in each build to downloading it
locally to a license.txt file, checking the file in and using it to store in the docker image.
This change is