Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add samples for loops #2218

Merged
merged 3 commits into from
Sep 24, 2019
Merged

Add samples for loops #2218

merged 3 commits into from
Sep 24, 2019

Conversation

kevinbache
Copy link
Contributor

@kevinbache kevinbache commented Sep 24, 2019

This change is Reviewable

@@ -0,0 +1,46 @@
# Copyright 2018 Google LLC

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: 2019

@numerology
Copy link

/lgtm
Thanks Kevin!
Remember to correct the year :)

@gaoning777
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm label Sep 24, 2019
@numerology
Copy link

/lgtm

@Ark-kun
Copy link
Contributor

Ark-kun commented Sep 24, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b52e32b into kubeflow:master Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants