Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build inverse proxy image as part of the presubmit test #2187

Merged
merged 9 commits into from
Sep 21, 2019

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Sep 21, 2019

/assign @Bobgy


This change is Reviewable

@Bobgy
Copy link
Contributor

Bobgy commented Sep 21, 2019

/test kubeflow-pipeline-e2e-test

@Bobgy
Copy link
Contributor

Bobgy commented Sep 21, 2019

/lgtm
/approve

@Bobgy
Copy link
Contributor

Bobgy commented Sep 21, 2019

@IronPan you accidentally touched manifests/market_place, so I cannot approve it. Can you approve by yourself?

@k8s-ci-robot k8s-ci-robot removed the lgtm label Sep 21, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy
Copy link
Contributor

Bobgy commented Sep 21, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 0711566 into kubeflow:master Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants