Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs - Added the direct kfp module members to documentation #2183

Merged

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Sep 21, 2019

Problem: We've added some members to the root of kfp module (not some sub-module). E.g. kfp.run_pipeline_function_on_kfp_cluster.
These members are not shown in the Python SDK reference docs.
The change auto-adds those members to the docs.

This change is Reviewable

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Sep 23, 2019

/retest

@numerology
Copy link

Can you update the PR description a bit so that I can get the context. Sorry I'm not familiar with this part. Thanks!

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Sep 26, 2019

Can you update the PR description a bit so that I can get the context. Sorry I'm not familiar with this part. Thanks!

Oh. I forgot the description. Added it.

@Ark-kun Ark-kun changed the title Docs - Added the kfp root members Docs - Added the direct kfp module members to documentation Sep 26, 2019
Copy link
Contributor

@SinaChavoshi SinaChavoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Oct 8, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5163a6f into kubeflow:master Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants