metadata: Deployment scripts update #2180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @neuromage |
|
/test kubeflow-pipeline-e2e-test |
neuromage
reviewed
Sep 20, 2019
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neuromage The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
Change to parameterize database_name, host and port for metadata deployment using config maps
dushyanthsc
force-pushed
the
dushyanthsc/parameterize-metadatadb
branch
from
d43dc1e
to
7340628
Compare
|
/hold cancel The issue was that config maps values were supposed to be quoted, I had missed that. |
|
/lgtm |
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
* Add support to Azure file share Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com> * Add test cases for Azure file share support Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com> * Use account access key auth for Azure file storage Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com> * Upgrade azure storage file share version Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com> * Pass Azure access key to storage initializer Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com> * Add separate function to build storage access key Signed-off-by: Suresh-Nakkeran <suresh.n@ideas2it.com> Co-authored-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to parameterize database_name, host and port for metadata deployment using config maps
This change is