Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components - Added AutoML Tables components and tests #2174

Merged
merged 12 commits into from
Sep 25, 2019
Merged

Components - Added AutoML Tables components and tests #2174

merged 12 commits into from
Sep 25, 2019

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Sep 19, 2019 •
edited
Loading

The sample runs for an hour and half, so it's not usable as sample test. Unfortunately it's impossible to reduce the AutoML model training time.

image

This change is Reviewable

@Ark-kun Ark-kun changed the title Components - Added AutoML Tables components Components - Added AutoML Tables components and tests Sep 19, 2019
animeshsingh
animeshsingh reviewed Sep 23, 2019
View reviewed changes
Copy link
Contributor

@animeshsingh animeshsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this is specific to gcp - best to put it in that folder?

SinaChavoshi
SinaChavoshi reviewed Sep 24, 2019
View reviewed changes
components/automl/create_dataset_for_tables/component.py Outdated Show resolved Hide resolved
components/automl/create_dataset_for_tables/component.py Outdated Show resolved Hide resolved
components/automl/create_model_for_tables/component.py Outdated Show resolved Hide resolved
components/automl/create_model_for_tables/component.py Outdated Show resolved Hide resolved
components/automl/create_model_for_tables/component.py Outdated Show resolved Hide resolved
components/automl/import_data_from_bigquery/component.py Outdated Show resolved Hide resolved
components/automl/create_dataset_for_tables/component.py Outdated Show resolved Hide resolved
components/automl/import_data_from_gcs/component.py Outdated Show resolved Hide resolved
components/automl/import_data_from_gcs/component.py Outdated Show resolved Hide resolved
components/automl/split_dataset_table_column_names/component.py Outdated Show resolved Hide resolved
SinaChavoshi
SinaChavoshi approved these changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@SinaChavoshi SinaChavoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Ark-kun
Revert "Replaced pip with pip3"
0c8680e 
This reverts commit 65ed0a7. (part of it)

Here, `pip` is not the name of executable. It's the module name which is
just `pip`, not `pip3`.
@k8s-ci-robot k8s-ci-robot removed the lgtm label Sep 25, 2019
@animeshsingh
Copy link
Contributor

animeshsingh commented Sep 25, 2019 •
edited
Loading

So my previous comment didn't get answered - is this specific to GCP? If yes, should it go in that folder? @Ark-kun @SinaChavoshi

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Sep 25, 2019

is this specific to GCP?

Yes.

If yes, should it go in that folder?

It's there.

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Sep 25, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

SinaChavoshi
SinaChavoshi approved these changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@SinaChavoshi SinaChavoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtml

@SinaChavoshi
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 4339e70 into kubeflow:master Sep 25, 2019
@gaoning777
Copy link
Contributor

Could we move this to the contrib, especially when there is no tests covering this sample? @Ark-kun

magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@cheng8994
Add aix-explainer deploy command (kubeflow#2174)
9592b3b 
* Add aix-explainer deploy command

Signed-off-by: Cheng8994 <nick20000904@gmail.com>

* Add aix-explainer deploy command

Signed-off-by: Cheng8994 <nick20000904@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@numerology numerology numerology left review comments

@animeshsingh animeshsingh animeshsingh left review comments

@SinaChavoshi SinaChavoshi SinaChavoshi approved these changes

@hongye-sun hongye-sun Awaiting requested review from hongye-sun

@gaoning777 gaoning777 Awaiting requested review from gaoning777

@kevinbache kevinbache Awaiting requested review from kevinbache

Assignees

@kevinbache kevinbache

@gaoning777 gaoning777

@numerology numerology

@SinaChavoshi SinaChavoshi

Labels
approved area/components area/samples/notebooks area/samples lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Ark-kun @animeshsingh @k8s-ci-robot @SinaChavoshi @gaoning777 @numerology @kevinbache