Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add URI to artifact details page #2157

Merged
merged 1 commit into from
Sep 19, 2019

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Sep 18, 2019

video: https://drive.google.com/file/d/1fASKYbU0JJPnV16MhE8J9EjbmiSYQOpb/view
@neuromage WDYT?

Part of #2086
/area front-end
/kind feature


This change is Reviewable

@Bobgy
Copy link
Contributor Author

Bobgy commented Sep 18, 2019

/assign @IronPan

@Bobgy
Copy link
Contributor Author

Bobgy commented Sep 19, 2019

@neuromage can you take a look at this too?

@neuromage
Copy link
Contributor

/lgtm
/approve
Nice!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neuromage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 08f4716 into kubeflow:master Sep 19, 2019
@Bobgy Bobgy deleted the fe_artifact_detail_uri branch September 19, 2019 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants