Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execution detail page shows inputs and outputs #2155

Merged
merged 10 commits into from
Sep 20, 2019

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Sep 18, 2019

Part of #2086

video 1 - initial implementation: https://drive.google.com/file/d/1ZegAxrewO_fDLHOZUkJ7JixPmpoOeMkc/view
video 2 - deep link in artifact id: https://drive.google.com/file/d/1UFPrBf7-afdu80uOLvDZLynxEnkmKcMR/view
Final screenshot
@neuromage Any feedback about this?

/area front-end
/kind feature
/assign @IronPan
/cc @neuromage


This change is Reviewable

@@ -1,10 +1,14 @@
{
"compilerOptions": {
"allowSyntheticDefaultImports": true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allows code like import React, { Component } from 'react'

@Bobgy
Copy link
Contributor Author

Bobgy commented Sep 18, 2019

Note, this is based on #2153
Changeset will be more focused when it is merged.

@neuromage
Copy link
Contributor

This is great, thanks @Bobgy!

Would it be possible to make the inputs/outputs linkable?

@Bobgy
Copy link
Contributor Author

Bobgy commented Sep 19, 2019

@neuromage it is already linkable. The first video were taken before I made the linkable feature.
take a look at the second video

@Bobgy
Copy link
Contributor Author

Bobgy commented Sep 20, 2019

Since @ajayalfred has LGTMed. I will merge this.
/approve

@Bobgy
Copy link
Contributor Author

Bobgy commented Sep 20, 2019

/lgtm

@k8s-ci-robot
Copy link
Contributor

@Bobgy: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@neuromage
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy, neuromage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7659e23 into kubeflow:master Sep 20, 2019
@Bobgy Bobgy deleted the executions_input_output branch September 20, 2019 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants