Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add artifact location tests #2142

Merged
merged 1 commit into from
Sep 17, 2019
Merged

add artifact location tests #2142

merged 1 commit into from
Sep 17, 2019

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Sep 17, 2019

This change is Reviewable

@Ark-kun
Copy link
Contributor

Ark-kun commented Sep 17, 2019

Thanks for fixing the sample
/lgtm

@Ark-kun
Copy link
Contributor

Ark-kun commented Sep 17, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaoning777 gaoning777 merged commit 759d2f6 into kubeflow:master Sep 17, 2019
@gaoning777 gaoning777 deleted the add-artifact-location-tests branch September 17, 2019 20:34
@gaoning777
Copy link
Contributor Author

fixing #1813

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants