Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes to the kfp marketplace #2138

Merged
merged 3 commits into from
Sep 17, 2019
Merged

Small fixes to the kfp marketplace #2138

merged 3 commits into from
Sep 17, 2019

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Sep 17, 2019 •
edited by jlewi
Loading

This change is Reviewable

@IronPan
Copy link
Member Author

IronPan commented Sep 17, 2019

/assign @rmgogogo

@k8s-ci-robot
Copy link
Contributor

@IronPan: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
kubeflow-pipeline-e2e-test 2a7f7e2 link /test kubeflow-pipeline-e2e-test
kubeflow-pipeline-sample-test 2a7f7e2 link /test kubeflow-pipeline-sample-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@IronPan
Copy link
Member Author

IronPan commented Sep 17, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rmgogogo
Copy link
Contributor

/lgtm

@IronPan
Copy link
Member Author

IronPan commented Sep 17, 2019

the tests should be irrelevant to the change.

@IronPan IronPan merged commit 6e0357d into kubeflow:master Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neuromage neuromage Awaiting requested review from neuromage

@paveldournov paveldournov Awaiting requested review from paveldournov

Assignees

@rmgogogo rmgogogo

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IronPan @k8s-ci-robot @rmgogogo