Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing execution name in execution list/detail page. #2135

Merged

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Sep 17, 2019

Bug: execution names are missing in execution list page.
After the fix: https://drive.google.com/file/d/1NJRFc8T5rWkSLJy_RbzT1yEJb4VyIgjz/view

Part of #2086

/assign @IronPan
/cc @neuromage
/kind bug
/area front-end


This change is Reviewable

@Bobgy Bobgy force-pushed the executions_use_component_id_as_name branch from 7943627 to da0f57e Compare September 17, 2019 02:26
@Bobgy Bobgy changed the title Fix missing execution name in execution list page. Fix missing execution name in execution list/detail page. Sep 17, 2019
@IronPan
Copy link
Member

IronPan commented Sep 17, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy
Copy link
Contributor Author

Bobgy commented Sep 17, 2019

/retest

1 similar comment
@Bobgy
Copy link
Contributor Author

Bobgy commented Sep 17, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 2106c8f into kubeflow:master Sep 18, 2019
@Bobgy Bobgy deleted the executions_use_component_id_as_name branch September 18, 2019 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants