Update gitignore to ignore all .iml files #2123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @rmgogogo |
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neuromage The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
* Add env field to ServingRuntime builtInAdapter settings Built-in runtimes that use the built-in adapter container have certain specific parameters configured via the builtInAdapter section in the CRD. However, there are certain other properties of the built-in runtimes that we may want to set/change for various reasons, so it would be good to extend this with a map of arbitrary environment variables to use for this purpose. Having this means that we can expose such additional properties for the built-in runtimes without requiring further changes to the CRD. Note this will currently only be applicable for the built-in modelmesh multi-model runtimes. Signed-off-by: Nick Hill <nickhill@us.ibm.com> * Rename struct fieldname to Env and re-generate openapi schema Signed-off-by: Nick Hill <nickhill@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/assign @Ark-kun
This change is