Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Components - Fixed kfp.components.set_default_base_image #2118

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Sep 13, 2019

This change is Reviewable

@kevinbache
Copy link
Contributor

not a great long-term solution but for now
/lgtm

@kevinbache
Copy link
Contributor

/approve

1 similar comment
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Sep 14, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun, kevinbache

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Sep 16, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit c4c0bb8 into kubeflow:master Sep 16, 2019
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* added protocolversion in servingruntime spec

Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>

* allow a list of protocol versions in servingruntime

Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>

* 1. added logic to list runtimes order by protocol v1, created timestamp and name
2. removed predictor protocolversion default to v1

Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>

* added protocolversion grpc-v1, grpc-v2 and updated protocol version sorting logic

Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>

* updated openapi, swagger

Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants