SDK - Containers - Fixed kfp.containers.get_default_image_builder #2116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
|
/approve |
Ark-kun
changed the title
Ark-kun
force-pushed
the
SDK---Containers---Fixed-kfp.containers._get_default_image_builder
branch
from
0b5e5ce
to
02056ae
Compare
|
/retest |
|
/lgtm |
|
/approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun, kevinbache The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
* Used default port for raw deployment as fail safe Used default port in case a container port is not provided Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Added test for raw deployment Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Made changes to make service reconciler to target agent port if batcher is configured. Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Added service forwarding to agent in case of logger with raw deployment Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Removed sleep used for debugging Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is