Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add execution order sample test #2114

Merged
merged 2 commits into from
Sep 16, 2019

Conversation

numerology
Copy link

@numerology numerology commented Sep 13, 2019

Part of #1813


This change is Reviewable

@Ark-kun
Copy link
Contributor

Ark-kun commented Sep 13, 2019

/lgtm
/approve

Is this sample not covered by the e2e basic tests?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the lgtm label Sep 14, 2019
@gaoning777
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit dc3c7a4 into kubeflow:master Sep 16, 2019
@numerology numerology deleted the add-exec-order-sample-test branch September 16, 2019 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants