Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sidecar sample test #2106

Merged
merged 6 commits into from
Sep 17, 2019
Merged

Add sidecar sample test #2106

merged 6 commits into from
Sep 17, 2019

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Sep 13, 2019 •
edited by jlewi
Loading

This change is Reviewable

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

1 similar comment
@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

@gaoning777 gaoning777 changed the title [WIP] add sidecar sample test Add sidecar sample test Sep 16, 2019
numerology
numerology reviewed Sep 16, 2019
View reviewed changes
test/sample_test.yaml Outdated Show resolved Hide resolved
@numerology
Copy link

/lgtm

@gaoning777
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the lgtm label Sep 16, 2019
@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@gaoning777 gaoning777 mentioned this pull request Sep 16, 2019
Closed
@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

2 similar comments
@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

@gaoning777
Copy link
Contributor Author

@numerology this one is ready to be merged. I've tried to run it couple of times and the sample tests consistently pass.

@numerology
Copy link

/lgtm

@gaoning777 gaoning777 merged commit 4f88a82 into kubeflow:master Sep 17, 2019
@gaoning777 gaoning777 deleted the add-sidecar-test branch September 17, 2019 16:32
@gaoning777
Copy link
Contributor Author

fixing #1813

magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@dependabot
Bump pillow from 9.0.0 to 9.0.1 in /python/custom_transformer (kubefl…
2da89bf 
…ow#2106)

Bumps [pillow](https://github.com/python-pillow/Pillow) from 9.0.0 to 9.0.1.
- [Release notes](https://github.com/python-pillow/Pillow/releases)
- [Changelog](https://github.com/python-pillow/Pillow/blob/main/CHANGES.rst)
- [Commits](python-pillow/Pillow@9.0.0...9.0.1)

---
updated-dependencies:
- dependency-name: pillow
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@numerology numerology numerology left review comments

@Ark-kun Ark-kun Awaiting requested review from Ark-kun

@IronPan IronPan Awaiting requested review from IronPan

Assignees

@Ark-kun Ark-kun

@numerology numerology

Labels
approved lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gaoning777 @numerology @k8s-ci-robot @Ark-kun