Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artifact list column creation time #2105

Merged
merged 4 commits into from
Sep 17, 2019

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Sep 13, 2019

Implements feature mentioned in #2086 (comment)

We should add a column showing the creation time of each artifact. In order to get this, we'll need to query the metadata API server for events, and find the associated event that produced any given artifact. The event will have a timestamp.

Implementation video: https://drive.google.com/file/d/1tk6rFIuFn2H3yt9rwA7RYOPj0Loxhq_P/view

Current trade off, we need to send an extra request for each artifact to get its creation time. Therefore

  • this is not scalable when artifact count is large.
  • this shows data very slowly only until all the data is ready.

Thoughts?
Ideal fix is letting backend provide an api that lists artifacts with their creation time.
Before that, I can probably first show other fields, and then show creation time when data is ready.

/area front-end


This change is Reviewable

frontend/start-dev.sh Outdated Show resolved Hide resolved
@Bobgy
Copy link
Contributor Author

Bobgy commented Sep 16, 2019

@neuromage Do you have any feedback on the demo video?

@Bobgy
Copy link
Contributor Author

Bobgy commented Sep 16, 2019

Note, this PR is based on #2104, I will merge that one first

@Bobgy
Copy link
Contributor Author

Bobgy commented Sep 16, 2019

/assign @IronPan

@Bobgy
Copy link
Contributor Author

Bobgy commented Sep 16, 2019

/retest

@neuromage
Copy link
Contributor

/lgtm
/approve

Thanks @Bobgy

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neuromage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4166e7a into kubeflow:master Sep 17, 2019
@Bobgy Bobgy deleted the artifact_column_creation_time branch September 17, 2019 06:12
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Bumps [pillow](https://github.com/python-pillow/Pillow) from 9.0.0 to 9.0.1.
- [Release notes](https://github.com/python-pillow/Pillow/releases)
- [Changelog](https://github.com/python-pillow/Pillow/blob/main/CHANGES.rst)
- [Commits](python-pillow/Pillow@9.0.0...9.0.1)

---
updated-dependencies:
- dependency-name: pillow
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants