feature parity between notebook sample and normal sample #2095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
|
/test kubeflow-pipeline-e2e-test |
|
/test kubeflow-pipeline-sample-test |
1 similar comment
|
/test kubeflow-pipeline-sample-test |
|
/test kubeflow-pipeline-e2e-test |
numerology
reviewed
Sep 12, 2019
numerology
reviewed
Sep 12, 2019
| @@ -103,10 +103,10 @@ def _compile(self): | |||
| nb_params = {} | |||
|
|
|||
| try: | |||
| with open(os.path.join(CONFIG_DIR, '%s.config.yaml' % self._test_name), 'r') as f: | |||
| config_file = os.path.join(CONFIG_DIR, '%s.config.yaml' % self._test_name) | |||
There was a problem hiding this comment.
this one should be correct.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaoning777 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
gaoning777
deleted the
add-support-for-notebook-output-dynamic-param
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add dynamic injection of notebook sample parameter: output
This change is