pipeline-lite/metadata: Update readme #2093
Conversation
|
/test kubeflow-pipeline-e2e-test |
manifests/kustomize/README.md
Outdated
| required secret object. | ||
|
|
||
| ``` | ||
| kubectl create secret generic mysql-credential --namespace <your-namespace> --from-literal=username=<your-mysql-username> --from-literal=password=<your-mysql-password> |
There was a problem hiding this comment.
What's the default username and password as used by APIServer? Is it still root and empty password? If so, let's mention that here, and tell the user to create it with these defaults.
Should we just create this secret as part of the deployment script? This should be the default, and we can call out that this is what needs to be changed by the user if re-using an existing DB (e.g. CloudSQL).
There was a problem hiding this comment.
The default is still "root" and empty password. Will update the doc to reflect this.
By deployment script you mean for Marketplace? I am sure if lite deployment has one?
There was a problem hiding this comment.
Sorry, I mean this pipeline-lite deployment, not marketplace.
Essentially, since the default user and pass is also used by APIServer, so why not create a secret that uses the same settings?
/cc @IronPan
There was a problem hiding this comment.
I like the idea, essential create a Secret object via yaml files and then use that across other components. Let me update the PR with that change.
|
/assign @neuromage |
|
/retest |
dushyanthsc
force-pushed
the
dushyanthsc/pipelines-lite-documentation
branch
from
c6477fa
to
595cc07
Compare
Change to create mysql credential K8 object as part of deployment
dushyanthsc
force-pushed
the
dushyanthsc/pipelines-lite-documentation
branch
from
595cc07
to
abaf129
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neuromage The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Change adds necessary instructions required to configure Kubernetes secretes required for metaata server deployment in Pipeline Lite deployments.
This change is