Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update sample readme for the new structure #2058

Merged
merged 4 commits into from
Sep 6, 2019
Merged

update sample readme for the new structure #2058

merged 4 commits into from
Sep 6, 2019

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Sep 6, 2019

Also temporarily disabled side_car sample due to its flaky behavior in sample test.

This change is Reviewable

samples/README.md Outdated Show resolved Hide resolved
samples/README.md Outdated Show resolved Hide resolved
@numerology
Copy link

/lgtm

@gaoning777
Copy link
Contributor Author

/approve

@k8s-ci-robot k8s-ci-robot removed the lgtm label Sep 6, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@numerology
Copy link

/lgtm

@numerology numerology closed this Sep 6, 2019
@numerology numerology reopened this Sep 6, 2019
@numerology
Copy link

/lgtm

@gaoning777 gaoning777 merged commit 60018e3 into kubeflow:master Sep 6, 2019
@gaoning777 gaoning777 deleted the add-sample-readme branch September 6, 2019 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants