Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Compiler - Fixed dsl.Condition when parameter resolves to string with spaces #2043

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Sep 5, 2019

Fixes #1950


This change is Reviewable

@Ark-kun Ark-kun changed the title SDK - Compiler - Quoting the predicate operands SDK - Compiler - Fixed dsl.Condition when parameter resolves to string with spaces Sep 5, 2019
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Sep 6, 2019

/retest

@numerology
Copy link

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Sep 6, 2019

/approve

1 similar comment
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Sep 6, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Sep 6, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit d83601d into kubeflow:master Sep 7, 2019
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to use a pipeline parameter containing spaces in Condition?
5 participants