SDK - Compiler - Fixed handling of PipelineParams in artifact arguments #2042
Conversation
Previously only constant strings were supported and serialized PipelineParams were not resolved, producing incorrect workflows.
|
/retest |
| @@ -138,6 +139,8 @@ def _inputs_to_json( | |||
| artifacts = [] | |||
| for name, path in (input_artifact_paths or {}).items(): | |||
| artifact = {'name': name, 'path': path} | |||
| if name in artifact_arguments: # The arguments should be compiled as DAG task arguments, not template's default values, but in the current DSL-compiler implementation it's too hard to make that work when passing artifact references. | |||
| artifact['raw'] = {'data': str(artifact_arguments[name])} | |||
There was a problem hiding this comment.
Sorry I'm not familiar with this. Are all artifacts guaranteed to be serializable?
There was a problem hiding this comment.
Good idea for the next PR.
Right now we only support two types of artifact arguments - constant string and PipelineParam reference to some task's output, which is also serializable.
In future I can put support for serializing complex types here so that it's on par with the component argument serialization support.
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ark-kun
deleted the
SDK---Compiler---Fixed-handling-of-PipelineParams-in-artifact-arguments
branch
Previously only constant strings were supported and serialized PipelineParams were not resolved, producing incorrect workflows.
This change is