SDK - Testing - Run some unit-tests in a more correct way #2036
Conversation
Replaced `@unittest.expectedFailure` with `with self.assertRaises(...):`. Replaced `assert` with `self.assertEqual(...)`. Stopped producing the stray "comp.yaml" file. Enabled the test_load_component_from_url test.
|
/retest |
|
/lgtm |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold There's an issue with getting this to merge. |
|
@chases2 Is it possible to fix the issue on our side or the only way is to stop using Travis? |
Ark-kun
force-pushed
the
SDK---Testing---Run-some-unit-tests-in-a-more-correct-way
branch
from
979a70d
to
55adcc4
Compare
|
/hold cancel |
|
@numerology Can you please re-LGTM - Travis checks have malfunctioned again. |
|
/lgtm |
kubeflow#2036) Bumps [tensorflow](https://github.com/tensorflow/tensorflow) from 2.5.2 to 2.5.3. - [Release notes](https://github.com/tensorflow/tensorflow/releases) - [Changelog](https://github.com/tensorflow/tensorflow/blob/master/RELEASE.md) - [Commits](tensorflow/tensorflow@v2.5.2...v2.5.3) --- updated-dependencies: - dependency-name: tensorflow dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Replaced
@unittest.expectedFailurewithwith self.assertRaises(...):.Replaced
assertwithself.assertEqual(...).Stopped producing the stray "comp.yaml" file.
Enabled the test_load_component_from_url test.
This change is