Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more core samples in the sample test #2030

Merged
merged 8 commits into from
Sep 6, 2019
Merged

add more core samples in the sample test #2030

merged 8 commits into from
Sep 6, 2019

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Sep 3, 2019

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added size/M and removed size/S labels Sep 3, 2019
Copy link
Member

@elikatsis elikatsis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have extended e2e tests in #2019, adding volume_ops in the tests.
So, I propose to revert the corresponding changes.

test/sample_test.yaml Outdated Show resolved Hide resolved
samples/core/volume_ops/volume_ops.py Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/S and removed size/M labels Sep 4, 2019
@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

@numerology
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm label Sep 5, 2019
@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

@numerology
Copy link

/lgtm

@gaoning777
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit fe0bc67 into kubeflow:master Sep 6, 2019
@gaoning777 gaoning777 deleted the add-sample-tests branch September 6, 2019 19:37
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants