Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update service account for non managed storage case #2023

Merged
merged 1 commit into from
Sep 3, 2019

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Sep 3, 2019

The deployment should use the generated service account for both managed storage and non managed storage case.

/assign @rmgogogo


This change is Reviewable

@IronPan
Copy link
Member Author

IronPan commented Sep 3, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor

Ark-kun commented Sep 3, 2019

/lgtm

@IronPan IronPan merged commit 4baf453 into kubeflow:master Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants