Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Components - Enable loading graph components #2010

Merged

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Aug 30, 2019

The graph components are now correctly loaded and instantiated (ContainerOps are created in the process).
Also added pre-configured ComponentStore.default_store.


This change is Reviewable

Copy link
Member

@ajchili ajchili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

sdk/python/kfp/components/_component_store.py Outdated Show resolved Hide resolved
sdk/python/kfp/components/_components.py Show resolved Hide resolved
The graph components are now correctly loaded and instantiated.
Also added pre-configured ComponentStore.default_store
@Ark-kun Ark-kun force-pushed the SDK---Components---Load-graph-components branch from 184520d to 446826e Compare August 30, 2019 20:50
@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 30, 2019
@ajchili
Copy link
Member

ajchili commented Aug 30, 2019

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Aug 30, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit efe9d87 into kubeflow:master Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants