Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update check experiment condition #201

Merged
merged 1 commit into from
Nov 12, 2018
Merged

Update check experiment condition #201

merged 1 commit into from
Nov 12, 2018

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Nov 11, 2018

Got following error otherwise

TypeError: object of type 'NoneType' has no len()

This change is Reviewable

Got following error otherwise
```
TypeError: object of type 'NoneType' has no len()
```
@IronPan
Copy link
Member Author

IronPan commented Nov 11, 2018

/assign @Ark-kun

@coveralls
Copy link

coveralls commented Nov 11, 2018

Pull Request Test Coverage Report for Build 222

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.506%

Totals Coverage Status
Change from base Build 220: 0.0%
Covered Lines: 1535
Relevant Lines: 2182

💛 - Coveralls

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 12, 2018

Thanks for catching this!

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 12, 2018

/lgtm

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 12, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 21869d6 into master Nov 12, 2018
@IronPan IronPan deleted the IronPan-patch-1 branch December 10, 2018 22:26
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
* Add TektonClient to SDK

Related kubeflow#197

* Import TektonClient in root __init__.py

Move tekton_api_version to compiler/__init__.py
to prevent circular import error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants