Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change schema.yaml to v2 #2009

Merged
merged 8 commits into from
Sep 3, 2019
Merged

Change schema.yaml to v2 #2009

merged 8 commits into from
Sep 3, 2019

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Aug 30, 2019 •
edited by jlewi
Loading

This change is Reviewable

Ark-kun
Ark-kun reviewed Aug 30, 2019
View reviewed changes
manifests/gcp_marketplace/deployer/Dockerfile Outdated
@@ -1 +1 @@
FROM gcr.io/cloud-marketplace-tools/k8s/deployer_helm/onbuild
FROM gcr.io/yang-experiment-6/marketplace-k8s-app-tools/k8s/deployer_helm/onbuild:unreleased-pr396
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this image change temporary?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated to permanent gcr

@IronPan IronPan changed the title [WIP] Change schema.yaml to v2 Change schema.yaml to v2 Sep 2, 2019
@IronPan
Copy link
Member Author

IronPan commented Sep 3, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rileyjbauer
rileyjbauer reviewed Sep 3, 2019
View reviewed changes
manifests/gcp_marketplace/deployer/Dockerfile
@@ -1 +1 @@
FROM gcr.io/cloud-marketplace-tools/k8s/deployer_helm/onbuild
FROM gcr.io/ml-pipeline/marketplace-k8s-app-tools/k8s/deployer_helm/onbuild:0829-pr396
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's with this tag? is it temporary?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes this is an unofficial image. the change is not in marketplace prod yet.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i talked with marketplace and using this should be fine for now.

manifests/gcp_marketplace/schema.yaml Outdated
title: GCP project
managedstorage.databaseNamePrefix:
type: string
title: databaes name prefix
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: database

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

james-jwu
james-jwu reviewed Sep 3, 2019
View reviewed changes
manifests/gcp_marketplace/chart/kubeflow-pipelines/values.yaml
databaseNamePrefix: null
gcpSecretName: null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sort

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@james-jwu
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@james-jwu: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rileyjbauer
Copy link
Contributor

/lgtm

@IronPan
Copy link
Member Author

IronPan commented Sep 3, 2019

/retest

@IronPan IronPan merged commit 8a87bd3 into kubeflow:master Sep 3, 2019
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@andyi2it
Add rollout duration feature (kubeflow#2009) (kubeflow#2300)
afb2b30 
* Add rollout duration feature for inferenceservice

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ark-kun Ark-kun Ark-kun left review comments

@rileyjbauer rileyjbauer rileyjbauer left review comments

@james-jwu james-jwu james-jwu left review comments

@neuromage neuromage Awaiting requested review from neuromage

@paveldournov paveldournov Awaiting requested review from paveldournov

Assignees

@rileyjbauer rileyjbauer

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@IronPan @k8s-ci-robot @james-jwu @rileyjbauer @Ark-kun