Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the bigquery components to fabvor the new gcp components #2006

Merged
merged 1 commit into from
Sep 3, 2019
Merged

remove the bigquery components to fabvor the new gcp components #2006

merged 1 commit into from
Sep 3, 2019

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Aug 30, 2019

Deleted since BQ has not been used by any samples and we also want to promote the better new GCP components.

This change is Reviewable

@numerology
Copy link

/lgtm

@gaoning777
Copy link
Contributor Author

/approve

@gaoning777
Copy link
Contributor Author

/retest

@numerology
Copy link

nit: typo in PR title fabvor -> favor

@k8s-ci-robot k8s-ci-robot removed the lgtm label Sep 3, 2019
@gaoning777
Copy link
Contributor Author

fixed.

@numerology
Copy link

/lgtm

@gaoning777
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c65111c into kubeflow:master Sep 3, 2019
@gaoning777 gaoning777 deleted the clean-old-bq branch September 3, 2019 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants