Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEST #20

Merged
merged 1 commit into from
Nov 2, 2018
Merged

TEST #20

merged 1 commit into from
Nov 2, 2018

Conversation

kubeflow-pipeline-bot
Copy link
Contributor

@kubeflow-pipeline-bot kubeflow-pipeline-bot commented Nov 2, 2018 •
edited by jlewi
Loading

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: vicaire

If they are not already assigned, you can assign the PR to them by writing /assign @vicaire in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

@vicaire vicaire merged commit c4c16cd into master Nov 2, 2018
@google-prow-robot
Copy link
Collaborator

@kubeflow-pipeline-bot: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
mlpipeline-build-image bd80ab7 link /test mlpipeline-build-image
mlpipeline-presubmit-unit-test bd80ab7 link /test mlpipeline-presubmit-unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@yuzisun @theofpa
@andyi2it @chinhuang007 @Iamlovingit @animeshsingh @js-ts
Merge kserve to main branch (kubeflow#1811)
638fff6 
* Change e2e test job to point to kserve repo

* Fix prow config

* Remove dir dep

* fix image-transformer built image tag (kubeflow#44)

* fix image-transformer built image tag

Signed-off-by: Theofilos Papapanagiotou <theofilos@gmail.com>

* rename ecr registry directory for kserve

Signed-off-by: Theofilos Papapanagiotou <theofilos@gmail.com>

* merging kserve branch to master (kubeflow#35)

* KServe Go module and API group change
--------------------------------------

Updated go source files with new go module.
Changed apigroup in yaml files.
Made changes in Makefile to represent the repository and apigroup names.

Verified `make test` is passing.

Removed reference for old names.

* Pointed correct repo reference for ko images (kubeflow#23)

* Rename changes python - New (kubeflow#19)

* python changes-initial-commit

* updated api gen.
Renamed package references in python.

* Renamed python/kfserving to python/kserve

* renamed python folder according to package kserve

* Ran client-gen. Updated swagger.json

* renamed constants from KFSERVING_ to KSERVE_.
Yet to change namespace from kfserving-system to kserve and hence not changed in python side.

* Updated kfserving reference to kserve
Updated version for Python Package Index to 0.7.0rc0
Renamed KFServingSampleModel to KServeSampleModel

* Python package and corresponding directory change has to be reflected in test and dockerfiles

* updated a specific version in requirments to address issue with pip resolver.
Added more specific versions in requirements,txt and updated paddleserver setup.py with kserve dependency.

* Changed namespace from kfserving-system to kserve (kubeflow#31)

* Update local dev scripts (kubeflow#33)

* initial commit of dev-scripts update

* Updated quick-install

* Updated python Makefile

* Generated install for new release

* Updated generate-install script with new release

* Reverting controller name in makefile.
Will be updated in separate pr.

* Github action changes (kubeflow#34)

* Github action changes

Migrated images publish to kserve repo.
Added github workflows for the ones that was being pushed to gcr.io from release/triggers.

* Removed batcher publisher since batcher.Dockerfile does not exist
Updated tf2openapi.Dockerfile  to correct directory and package.

* Fixed issue with working directory of tf2openapi workflow

* Removed the deptrecated logger docker

* Excluded tests from linting. (kubeflow#36)

They were pointing to older directory and package names and
hence were not being excluded while linting.

* Update license (kubeflow#20)

* Fixed errors thrown by flake8 linter (kubeflow#37)

* Kfserving kserve manifests changes and code reference changes (kubeflow#39)

* kfserving -> kserve migartion initial commit

* kfserving -> kserve config changes

* Changed constants.
Updated image reference from kserve to andyarok

* Reverted kserve models web app  image repo.

* go changes for kfserving-kserve

* Updated KFServing refernce in python code

* Updated KFServing to KServe in python doc comments.
Updated references of v1alpha2 from duplicate aliases to just use pkg name.
Updated docs samples references with proper name.
Made changes to use Constant for container name instead of literal "kserve-container".

* Updated gitignore for generated files that came in after folder rename.
Removed the generated files.
Fixed lint warnings for go.

* Removed travis yml file.

* KServe doc update (kubeflow#38)

* Update main and pythonserver readme

* Update python docs

* Fix role binding

* Update kserve sdk doc

* Fix e2e test script

* Fix import

* Kserve error fix (kubeflow#40)

* Fixed linting errors in python

* Fixed make test.
Issue with storage initializer name/path.

* Fixed failing python test.
Updated ray version.
Updated KFServingClient reference to KServeClient in kserve init.

* Updated ray version from 1.4.0 to 1.5.0

* Fixed error with e2e due to kfserving reference in test overlay (kubeflow#42)

Updated quick install and added 0.7.0-rc0 install manifests.
Updated e2e namespace.

* Controller repo update (kubeflow#45)

Made changes in workflow to update image repo to kserve instead of kfserving

* Controller repo update (kubeflow#45)

Made changes in workflow to update image repo to kserve instead of kfserving

* update pytorch image

* Fix transformer dockerfile

Co-authored-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Co-authored-by: andyi2it <87992092+andyi2it@users.noreply.github.com>

* Generate 0.7.0 release candidate and update roadmap/release process (kubeflow#46)

* Fix apiVersion for examples and docs (kubeflow#55)

Fix apiVersion for examples and docs change from serving.kubeflow.org
to serving.kserve.io

* add default deployment and fix startup without knative to master branch (kubeflow#57)

* add default deployment and fix startup without knative

* fix suite_test error

* fix suit_test error

* add constant vb for RawDeployment and Serverless

* update predictor string RawDeployment to constants.RawDeployment

* modify getDeploymentMode return type

* Update kserve layer diagram (kubeflow#58)

* update diag (kubeflow#59)

* Remove kubeflow copyright (kubeflow#56)

* Adding kfs_architect.drawio and changing kfs_architect.png's "KFserving" name to "KServe" (kubeflow#60)

* Delete kfs_architect.png

* Add files via upload

Adding kfs_architect.drawio and changing kfs_architect.png's "KFserving" name to "KServe"

* Delete kfs_architect.png

* Delete kfs_architect.drawio

* added Metric scrapping title

* Delete kfs_architect.png

* Delete kfs_architect.drawio

* fixed typo

* add Nick Hill as a reviewer (kubeflow#66)

also removing rkelkar

* Separate out web-app repo (kubeflow#68)

* Sepate out web-app repo

* Remove models web-app github action

* Fix feast example

Co-authored-by: Theofilos Papapanagiotou <theofilos@gmail.com>
Co-authored-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Co-authored-by: andyi2it <87992092+andyi2it@users.noreply.github.com>
Co-authored-by: Chin Huang <chhuang@us.ibm.com>
Co-authored-by: Qingshan Chen <38182824+Iamlovingit@users.noreply.github.com>
Co-authored-by: Animesh Singh <singhan@us.ibm.com>
Co-authored-by: js-ts <79689323+js-ts@users.noreply.github.com>
HumairAK pushed a commit to HumairAK/data-science-pipelines that referenced this pull request Mar 6, 2024
@openshift-merge-bot
Merge pull request kubeflow#20 from hbelmiro/cherry-pick-cannot-save-…
c9916af 
…parameters

fix(backend): fixes "cannot save parameter" error message. Fixes kubeflow#9678 (kubeflow#10459)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ark-kun Ark-kun Awaiting requested review from Ark-kun

@vicaire vicaire Awaiting requested review from vicaire

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kubeflow-pipeline-bot @k8s-ci-robot @googlebot @google-prow-robot @vicaire