SDK - Components - Added type to TaskOutputReference #1995
Conversation
Now the task output references taken from TaskSpec instances can be type-checked when passed to components.
|
/retest |
| @@ -65,12 +65,14 @@ | |||
| PrimitiveTypes = Union[str, int, float, bool] | |||
| PrimitiveTypesIncludingNone = Optional[PrimitiveTypes] | |||
|
|
|||
| TypeType = Union[str, Dict, List] | |||
There was a problem hiding this comment.
Should we rename this type? Would ContainerType or something similar be appropriate?
There was a problem hiding this comment.
This is the python type describing the type of the component input type.
So it's "[python] type of [input/output] type"
There was a problem hiding this comment.
Gotcha, would it make sense to indicate that? Such as TypeIO or IOType.
There was a problem hiding this comment.
Renamed it to TypeSpecType. It's also used for task arguments and some other properties...
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Now the task output references taken from TaskSpec instances can be
type-checked when passed to components.
This change is