Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tedious redefinition using withItem. #1985

Merged
merged 1 commit into from
Aug 29, 2019

Conversation

numerology
Copy link

@numerology numerology commented Aug 28, 2019

Use withItems to reduce the duplicated definition in e2e test yaml.

Part of #1750


This change is Reviewable

@Ark-kun
Copy link
Contributor

Ark-kun commented Aug 28, 2019

/lgtm

@numerology
Copy link
Author

/approve

1 similar comment
@gaoning777
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777, numerology

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@numerology numerology merged commit 63483b6 into kubeflow:master Aug 29, 2019
@numerology numerology deleted the change-e2e-test-to-withitem branch August 29, 2019 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants