Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Tests - Fixed bug in the Artifact location test pipeline #1982

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Aug 28, 2019

The pipeline had non-uniqe template names due to pipeline name being the same as one task name.
The root issue will be fixed by https://github.com/lubeflow/pipelines/pulls/1555


This change is Reviewable

The pipeline had non-uniqe template names due to pipeline name being the same as one task name.
The root issue will be fixed by https://github.com/lubeflow/pipelines/pulls/1555
@ajchili
Copy link
Member

ajchili commented Aug 28, 2019

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Aug 28, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun Ark-kun merged commit 27de9e3 into kubeflow:master Aug 28, 2019
@Ark-kun Ark-kun deleted the SDK---Tests---Fixed-bug-in-the-Artifact-location-test-pipeline branch August 28, 2019 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants