Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stdout/stderr from predefined visualization #1976

Conversation

ajchili
Copy link
Member

@ajchili ajchili commented Aug 28, 2019

This change is Reviewable

Now, non-custom visualizations will not show stdout and stderr messages to a user.
@ajchili
Copy link
Member Author

ajchili commented Aug 28, 2019

/assign @IronPan @neuromage

@ajchili
Copy link
Member Author

ajchili commented Aug 29, 2019

/hold
Investigating usage of nbconvert metadata to prevent multiple template files.

@ajchili ajchili changed the title Add new visualization template to remove stdout/stderr from generated visualization Remove stdout/stderr from predefined visualization Aug 29, 2019
@ajchili
Copy link
Member Author

ajchili commented Aug 29, 2019

/hold cancel

@ajchili
Copy link
Member Author

ajchili commented Aug 29, 2019

/assign @Ark-kun

…py due to changes made to create_cell_from_file function
@IronPan
Copy link
Member

IronPan commented Aug 30, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 69d0328 into kubeflow:master Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants