Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GCP marketplace deployer dockerfile #1975

Merged
merged 2 commits into from
Aug 28, 2019
Merged

Update GCP marketplace deployer dockerfile #1975

merged 2 commits into from
Aug 28, 2019

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Aug 28, 2019

The previous dockerfile throws me following exception

Traceback (most recent call last):
  File "/bin/set_ownership.py", line 127, in <module>
    main()
  File "/bin/set_ownership.py", line 80, in main
    "Application kind".format(args.manifests))
Exception: Set of resources in /data/manifest-expanded includes more than one of Application kind

Not sure what happens but the new dockerfile works.


This change is Reviewable

@IronPan IronPan changed the title Update docker Update GCP marketplace deployer dockerfile Aug 28, 2019
@IronPan
Copy link
Member Author

IronPan commented Aug 28, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ajchili
Copy link
Member

ajchili commented Aug 28, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 28, 2019
@ajchili
Copy link
Member

ajchili commented Aug 28, 2019

/lgtm

@IronPan IronPan merged commit 52d3ef5 into master Aug 28, 2019
@IronPan IronPan deleted the IronPan-patch-1 branch September 19, 2019 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants