manifest/metadata: Switching to use metadata grpc server #1973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @gaoning777 |
|
/hold Putting a hold as the metadata grpc docker image is not yet published. |
dushyanthsc
commented
Aug 28, 2019
| "--mysql_service_host=mysql", | ||
| "--mysql_service_port=3306", | ||
| "--mlmd_db_name=metadb"] | ||
| image: gcr.io/kubeflow-images-public/ml_metadata_store_server:0.14.0 |
There was a problem hiding this comment.
TODO: Double check to make sure that the gcr repository is correct.
There was a problem hiding this comment.
Done. Updated to use gcr.io/tfx-oss-public gcr.
dushyanthsc
force-pushed
the
dushyanthsc/pipeline-lite-metadata-rpc
branch
from
7a95ef4
to
ee5b6ae
Compare
This change switches pipeline deployments to use metadata-grpc server instead of kf-mlmd server.
dushyanthsc
force-pushed
the
dushyanthsc/pipeline-lite-metadata-rpc
branch
from
ee5b6ae
to
4591785
Compare
|
/hold cancel The image is verified and published. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neuromage The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
* Organise handlers into separate files Signed-off-by: Mark Winter <mark.winter@navercorp.com> * no lint init file imports Signed-off-by: Mark Winter <mark.winter@navercorp.com> * apply review Signed-off-by: Mark Winter <mark.winter@navercorp.com> * lint Signed-off-by: Mark Winter <mark.winter@navercorp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change switches pipeline deployments to use metadata-grpc server instead of kf-mlmd server.
This change is